Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Info Page for Community Channels #616

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

omsuneri
Copy link
Member

@omsuneri omsuneri commented Dec 29, 2024

Creating Informative Page for the Community Channel
New page in website provides more understanding to the community channel for chat and discussion

@omsuneri
Copy link
Member Author

@quozl @pikurasa i had created this page as decided in last Meet of web dev please review this as this resolves all the previous conflicts too

@omsuneri
Copy link
Member Author

@quozl this time I add all the files in a single commit as they all are added to to create a single page only so is it the correct way or any changes required

@retrogtx
Copy link

looks very nice!

@omsuneri
Copy link
Member Author

Thanks @retrogtx

Copy link
Contributor

@quozl quozl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • our guide to making commit messages has not been followed,
  • the screenshots do not scale,
  • the screenshots do not follow browser dark and light mode preferences.

I'd be happy not to have screenshots.

@pikurasa
Copy link
Contributor

My idea for screenshots were to help a newbie understand what to see when navigating creating an account for the first time.

I don't think you should use those screenshots.

This is more of what I was thinking of:

Screenshot from 2024-12-26 11-08-26

In fact, that one screenshot is probably sufficient.

We may want to also find an "official" how-to for registering to Matrix for the first time that we can link to, so that we know we're sending people to something that's probably always up-to-date, and that we don't have to maintain ourselves.

@omsuneri
Copy link
Member Author

omsuneri commented Dec 30, 2024

@pikurasa okay so i ll be deleting the images and also trying to add more text information about the make account creation and also try to search some matrix link to their guide for creating an account for matrix and again similar for discord too.

@pikurasa
Copy link
Contributor

@pikurasa okay so i ll be deleting the images and also trying to add more text information about the make account creation and also try to search some matrix link to their guide for creating an account for matrix and again similar for discord too.

Yes. If you have any questions, please let me know.

@omsuneri
Copy link
Member Author

Yeah @pikurasa I ll be making this soon as in my device I m getting many dependencies issue with the www repo I m trying to reset it @haroon10725 just wait for some as I did many changes if It not possible by you can surely take this issue but wait for sometime atleast

@haroon10725
Copy link
Contributor

@omsuneri No problem, will continue from here.

@omsuneri
Copy link
Member Author

@haroon10725 I ll inform you if it works me on 01/16 meet will discuss about this topic

@omsuneri
Copy link
Member Author

@pikurasa now i m having a fedora Virtual Machine on my mac through which i can run the repo and will be resolving all the conflicts and making this PR to be done by tomorrow

@omsuneri
Copy link
Member Author

@pikurasa as the elements create ac page should i also add the same for the discord too as we are displaying the info about both the paltforms so might be good to add both the platform create acc page

@omsuneri
Copy link
Member Author

@pikurasa @quozl i tried to make the required changes in this please review it now

@quozl
Copy link
Contributor

quozl commented Feb 1, 2025

  • do not change airspace.css thanks,
  • rewrite your commit messages following our guidance,
  • reduce the number of commits.

https://github.com/sugarlabs/sugar-docs/blob/master/src/contributing.md#making-commits

You should be reading existing commits in a repository and matching or uplifting the change and commit message style. Also read closed issues and pull requests. When we see work submitted without any evidence of this, it scores very badly.

You can do what we've asked without closing the pull request and opening a new one, by rebasing your branch and force push.

@omsuneri
Copy link
Member Author

omsuneri commented Feb 2, 2025

@quozl i tried to resolve all of the conflicts according to your suggestions

@omsuneri
Copy link
Member Author

omsuneri commented Feb 2, 2025

@pikurasa all conflicts with master are resolved please review it again

@quozl
Copy link
Contributor

quozl commented Feb 2, 2025

You haven't done any of the changes I asked for;

  • do not change airspace.css thanks,
  • rewrite your commit messages following our guidance,
  • reduce the number of commits.

Try harder.

@omsuneri
Copy link
Member Author

omsuneri commented Feb 2, 2025

Sorry @quozl but I moved the css from airspace to custom
Also for the older commits should I also change their commit message too and about the new changes what I did now how can I reduce the commit numbers

@MostlyKIGuess
Copy link
Member

Sorry @quozl but I moved the css from airspace to custom
Also for the older commits should I also change their commit message too and about the new changes what I did now how can I reduce the commit numbers

What he meant was that file is changed unnecessarily, so that could be removed, use

git rebase -i

To rebase and squash the commits so that you remove unnecessary commits and make commits as per what changes you are making clearly stating what each commit did.

@quozl
Copy link
Contributor

quozl commented Feb 3, 2025

There are many ways to reduce the commits, interactive rebase offers some ways, as does a reset followed by new commits. Look at Git documentation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image seems good to me, but please optimize the image. You should be able to make it smaller.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i m unable to understand the requirement can you describe more please @pikurasa

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a png to jpeg or jpg converter and use that instead, keeping a file size like this causes the site to slow down

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image seems good to me, but please optimize the image. You should be able to make it smaller.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pikurasa can you describe more

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a png to jpeg or jpg converter and use that instead, keeping a file size like this causes the site to slow down

@omsuneri
Copy link
Member Author

omsuneri commented Feb 5, 2025

@pikurasa i resolved all the conflicts with this PR check it once

js/custom.js Outdated
@@ -17,54 +17,48 @@ function toggleAnswer(answerId, element) {
// Counter Animation of the home page
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah changes on this file are just not required

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a png to jpeg or jpg converter and use that instead, keeping a file size like this causes the site to slow down

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a png to jpeg or jpg converter and use that instead, keeping a file size like this causes the site to slow down

@@ -2777,7 +2777,7 @@ font-size:30px;
.try-mb:active {
top:0.1em;
color: #fff !important;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unintended change

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unintended change

@quozl
Copy link
Contributor

quozl commented Feb 5, 2025

Please remove your unintended change to css/airspace.css

You can and should do this without opening a new pull request; use standard git techniques to restore the file to the point it was before your work, then commit the file alone.

We could do it for you, but we'd prefer you do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants